Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Connect & MongoDB Database #74

Merged
merged 13 commits into from
May 30, 2024
Merged

Kafka Connect & MongoDB Database #74

merged 13 commits into from
May 30, 2024

Conversation

Michael7371
Copy link

PR Details

Description

This PR includes an additional docker-compose file named: "docker-compose-mongo.yml" which stands up a MongoDB database with a kafka connect instance to sink topics specified in the ./jpo-s3-deposit/mongo-connector/connect_start.sh script.

This PR also makes a change to the new kafka instance to use a docker managed kafka volume rather than a bind mount docker volume. This improves the performance of kafka (especially for windows users) by keeping everything in the docker file system. This is also helpful as now the kafka data can be reset if you attach the -v tag when using docker compose down -v command.

Related Issue

No related issue.

Motivation and Context

The move to have this functionality in the core ODE environment comes from combining requirements from the jpo-conflictmonitor and the jpo-cvmanager. When deploying in a local environment both of these will require kafka connect and a MongoDB instance to work from.

How Has This Been Tested?

If you stand up the mongo environment with the command: docker compose -f .\docker-compose-mongo.yml up -d, the standard ODE environment will be stood up along with the Mongo and kafka connect container. There is also a MongoDB configuration container that provisions users for RBAC. Please make sure to update your .env file with the new MongoDB required environmental variables from the sample.env

Types of changes

  • [ x ] Defect fix (non-breaking change that fixes an issue)
  • [ x ] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • [ x ] I have added any new packages to the sonar-scanner.properties file
  • [ x ] My change requires a change to the documentation.
  • [ x ] I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Michael7371
Copy link
Author

Requires this PR to be merged first: #71

@Michael7371 Michael7371 marked this pull request as ready for review May 3, 2024 00:21
@drewjj
Copy link
Collaborator

drewjj commented May 17, 2024

Got a small conflict with the README

@Michael7371
Copy link
Author

Got a small conflict with the README

Okay, that's fixed now!

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit b0b7f37 into dev May 30, 2024
4 checks passed
@payneBrandon payneBrandon deleted the mongo-archiving branch May 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants