Set NTCIP1218 msgRepeatOption value based on context #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewjj
approved these changes
May 17, 2024
dmccoystephenson
deleted the
feature/set-msgRepeatOptions-based-on-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
The NTCIP1218 msgRepeatOptions value passed to RSUs is now set depending on the signing context of the ODE. If the ODE is configured to sign messages for RSUs, the value will be set to 0x00 to ensure the message doesn't get double-signed. If the ODE is configured to forward messages to RSUs without signing them first, the value will be set to 0x80 to ensure the RSU signs them before broadcasting.
Dependent PR
It should be noted that this PR depends on #67 and should be merged after.
Related Issue
No related GitHub issue.
Motivation and Context
The correct value to be set for the NTCIP1218 msgRepeatOption depends on whether or not the message being forwarded to an RSU is signed. Previously, this value was hardcoded.
How Has This Been Tested?
Unit tests have been updated and verified to be passing.
It should be noted that these changes have not been tested against an RSU, but using 0x80 has previously been verified to result in a successful deposit when depositing unsigned messages to an RSU expecting the NTCIP1218 protocol.
Types of changes
Checklist:
ODE Contributing Guide