Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Release_notes.md for 2.1.0 release #80

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

dmccoystephenson
Copy link
Member

PR Details

Description

The release notes for the 2.1.0 release have been added to Release_notes.md.

Related Issue

No related GitHub issue.

Motivation and Context

A new version of the ODE will be released next month, and getting the release notes drafted is a prerequisite for this.

How Has This Been Tested?

Documentation change, no testing necessary.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)
  • Documentation change

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Dependent PR

Some of the changes mentioned are still in PR review. This PR can be merged after #74 and #78.

Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and makes sense. Just one comment regarding the paragraph.

Version 2.1.0, released June 2024
----------------------------------------
### **Summary**
The updates for the jpo-ode 2.1.0 release include several key improvements and fixes. These updates address issues with PSM and log offloading, and enhance the continuous integration processes. The Kafka version has been upgraded, and a bug related to log processing has been resolved. Nanoseconds are now trimmed from timestamps, and 1609.2 headers are now stripped from unsigned messages. A submodule compatibility guide has been added, along with making the default SNMP protocol configurable. Configurable signing is now possible independently for Road Side Units (RSUs) and the SDX. The Dockerhub documentation now includes a link to the submodule compatibility guide. Maven plugin versions have been updated, and the Kafka topic creation process has been improved. A timestamp precision bug has been fixed, and the documentation has been revised for accuracy. Additionally, the NTCIP1218 msgRepeatOptions value is now set based on context, and SnmpSession now reports failures to retrieve authoritative engine IDs only if a response is received. Finally, the TimDeleteController has been updated to log message deletion failures as errors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest deal, but generally when you have a short sentence with an 'and' you generally don't need a comma before the 'and'. You have a lot of sentences here like "The Kafka version has been upgraded, and a bug related to log processing has been resolved" where the comma doesn't make a whole lot of sense. It might be how you would naturally pause if you said it out loud but the statement is perfectly fine without a comma.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for highlighting this! I have adjusted the commas where 'and' is being used.

@dmccoystephenson dmccoystephenson marked this pull request as ready for review May 31, 2024 22:32
Copy link
Collaborator

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple changes I would make.

Version 2.1.0, released June 2024
----------------------------------------
### **Summary**
The updates for the jpo-ode 2.1.0 release include several key improvements and fixes. These updates address issues with PSM and log offloading and enhance the continuous integration processes. The Kafka version has been upgraded and a bug related to log processing has been resolved. Nanoseconds are now trimmed from timestamps and 1609.2 headers are now stripped from unsigned messages. A submodule compatibility guide has been added, along with making the default SNMP protocol configurable. Configurable signing is now possible independently for Road Side Units (RSUs) and the SDX. The Dockerhub documentation now includes a link to the submodule compatibility guide. Maven plugin versions have been updated and the Kafka topic creation process has been improved. A timestamp precision bug has been fixed and the documentation has been revised for accuracy. Additionally, the NTCIP1218 msgRepeatOptions value is now set based on context and SnmpSession now reports failures to retrieve authoritative engine IDs only if a response is received. Finally, the TimDeleteController has been updated to log message deletion failures as errors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically if you are going to spell out RSU, it would be "Roadside Unit". You could make it "Road-Side Unit" if you want to make it similar to OBU with "On-Board Unit"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Road-Side Unit

CDOT PR 67: Added configurable signing independently for RSUs and the SDX
CDOT PR 69: Added link to submodule compatibility guide to dockerhub documentation
CDOT PR 70: Updated maven plugin versions
CDOT PR 71: Updated kafka topic creation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets capitalize Kafka here since it is done elsewhere in these notes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalized!

CDOT PR 65: Added support for retaining IEEE 1609.2 security headers
CDOT PR 66: Made default SNMP protocol configurable
CDOT PR 67: Added configurable signing independently for RSUs and the SDX
CDOT PR 69: Added link to submodule compatibility guide to dockerhub documentation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is referred to as "Docker Hub" instead of all one word. This is based off my google results. Not confident here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Docker Hub

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmccoystephenson dmccoystephenson merged commit 7ff2d04 into dev Jun 5, 2024
4 checks passed
@dmccoystephenson dmccoystephenson deleted the docs/update-release-notes-2024-q2 branch June 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants