Resolving merge conflicts on USDOT ODE PR #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders JPO-ODE Hotfix for Security Headers
Sync Develop with Master
mwodahl
reviewed
Jun 4, 2024
| @@ -119,6 +119,7 @@ public class OdeProperties implements EnvironmentAware { | |||
| private Set<String> kafkaTopicsDisabledSet = new HashSet<>(); | |||
|
|
|||
| // BSM | |||
| private final String BSM_START_FLAG = "0014"; | |||
There was a problem hiding this comment.
These strings were moved into the UperUtil class in #78 . Are they currently used anywhere from the OdeProperties class? If not I don't believe we should add these back in.
There was a problem hiding this comment.
Thanks for this! These have been removed & the unit tests have been verified to be passing still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are merge conflicts on usdot-jpo-ode#547.
Solution
The merge conflicts have been resolved by merging USDOT's develop branch into CDOT dev.
Testing
Unit tests have been verified to pass with these changes.