-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for jpo-s3-deposit 1.5.0 #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small capitalization things.
docs/Release_notes.md
Outdated
Version 1.5.0, released June 2024 | ||
---------------------------------------- | ||
### **Summary** | ||
The changes for the jpo-s3-deposit 1.5.0 release include updated hard-coded kafka properties to be configurable, added support for GCS BLOB storage & an updated java version for the dev container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets capitalize Kafka in these notes. There are a few occurrences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalized!
docs/Release_notes.md
Outdated
Version 1.5.0, released June 2024 | ||
---------------------------------------- | ||
### **Summary** | ||
The changes for the jpo-s3-deposit 1.5.0 release include updated hard-coded kafka properties to be configurable, added support for GCS BLOB storage & an updated java version for the dev container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also want to capitalize Java.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalized!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Problem
Next month we will be releasing a new version of this project. Release notes need to be prepared.
Solution
The
Release_notes.md
file has been updated for the 1.5.0 release.Dependent PR
Some of the changes mentioned are still in PR review. This PR can be merged after #19.