Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actions Artifact Publishing #23

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Github Actions Artifact Publishing #23

merged 9 commits into from
Jul 3, 2024

Conversation

Michael7371
Copy link

@Michael7371 Michael7371 commented Jun 10, 2024 •
edited
Loading

Added GitHub action workflow to publish a java artifact to the GitHub repository whenever a release is created.

@Michael7371 Michael7371 marked this pull request as ready for review June 10, 2024 18:57
dmccoystephenson
dmccoystephenson requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me; has it been tested?

@Michael7371
Copy link
Author

This looks good to me; has it been tested?

Yes, here is a published artifact from a test run: https://github.com/CDOT-CV/jpo-s3-deposit/packages/2175004

dmccoystephenson
dmccoystephenson approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

drewjj
drewjj approved these changes Jun 12, 2024
View reviewed changes
Copy link

@drewjj drewjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iyourshaw
Copy link

Looks good!

Only comment is I notice in your test run the version is a SNAPSHOT, which is fine for testing, but I'd recommend removing that from the version number in the pom for the actual release. (SNAPSHOT makes the artifacts mutable which could be confusing to consumers of them)

@Michael7371
Copy link
Author

Looks good!

Only comment is I notice in your test run the version is a SNAPSHOT, which is fine for testing, but I'd recommend removing that from the version number in the pom for the actual release. (SNAPSHOT makes the artifacts mutable which could be confusing to consumers of them)

Good idea! I added a step to the pipeline that should remove the '-SNAPSHOT' from the pom file before building and publishing the artifact.

payneBrandon
payneBrandon requested changes Jun 13, 2024
View reviewed changes
Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question, looks good!

payneBrandon
payneBrandon approved these changes Jul 3, 2024
View reviewed changes
Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 089318f into dev Jul 3, 2024
2 checks passed
@payneBrandon payneBrandon deleted the cicd-artifact-publishing branch July 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewjj drewjj drewjj approved these changes

@dmccoystephenson dmccoystephenson dmccoystephenson approved these changes

@payneBrandon payneBrandon payneBrandon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Michael7371 @iyourshaw @payneBrandon @dmccoystephenson @drewjj