Files workflow #169
Merged
Files workflow #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpsherva
commented
Jul 25, 2024
•
kpsherva
commented
- closes Migration dedicated node cds-rdm#175
kpsherva
force-pushed
the
files-workflow
branch
4 times, most recently
from
1b94903
to
4eba27b
Compare
jrcastro2
approved these changes
Jul 25, 2024
| @@ -355,3 +355,4 @@ def _(x): # needed to avoid start time failure with lazy strings | |||
| base_path = os.path.dirname(os.path.realpath(__file__)) | |||
| logs_dir = os.path.join(base_path, "tmp/logs/") | |||
| CDS_MIGRATOR_KIT_LOGS_PATH = logs_dir | |||
| INVENIO_CDS_MIGRATOR_KIT_STREAM_CONFIG = "cds_migrator_kit/rdm/migration/streams.yaml" | |||
There was a problem hiding this comment.
minor: I would remove invenio
Suggested change
| INVENIO_CDS_MIGRATOR_KIT_STREAM_CONFIG = "cds_migrator_kit/rdm/migration/streams.yaml" | |
| CDS_MIGRATOR_KIT_STREAM_CONFIG = "cds_migrator_kit/rdm/migration/streams.yaml" |
| @@ -7,11 +7,19 @@ | |||
|
|
|||
| """CDS-RDM migration load module.""" | |||
|
|
|||
| import os | |||
There was a problem hiding this comment.
Minor: This can be removed
zzacharo
approved these changes
Jul 25, 2024
zzacharo
reviewed
Jul 25, 2024
| parent_dest_path = os.path.dirname(destination_path) | ||
| if not os.path.exists(parent_dest_path): | ||
| os.makedirs(parent_dest_path) | ||
| shutil.copy(full_path, destination_path) |
There was a problem hiding this comment.
discussed to use the eosclient and permission based tokens that should replace the copy command here and the need for kinit
zzacharo
reviewed
Jul 25, 2024
|
|
||
| ```shell | ||
| ssh cds-wn-31 # inveniomigrator tool installed here | ||
| kinit cdsrdmeosdev |
There was a problem hiding this comment.
see comment about using eosclient instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.