Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data quality #189

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Data quality #189

merged 1 commit into from
Oct 25, 2024

Conversation

kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Oct 24, 2024 •
edited
Loading

ntarocco
ntarocco approved these changes Oct 25, 2024
View reviewed changes
cds_migrator_kit/rdm/migration/transform/transform.py
message=f"Affiliation {affiliation_name} not found.",
stage="vocabulary match",
)
for affiliation_name in affiliations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is re-done by @zzacharo right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

cds_migrator_kit/rdm/migration/transform/xml_processing/rules/base.py
"""Translates identifiers: ALEPH.

Attention: 035 might contain aleph number
https://github.com/CERNDocumentServer/cds-migrator-kit/issues/21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aleph n. should also be added as an alternative identifier, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, and it is already done.
The comment there is pointing to other collections which have aleph in 035 (as of investigation from Ludmila) so I left it there as a reminder to check for the future

scripts/copy_collection_files.py
for legacy_record_file in legacy_record_files:
print("Processing {}".format(recid))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Processing {}".format(recid))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one was there on purpose, otherwise the script just goes on silently and the status in unknown

@zzacharo zzacharo merged commit 2eb68f4 into CERNDocumentServer:master Oct 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzacharo zzacharo zzacharo left review comments

@ntarocco ntarocco ntarocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sspn: migration rules
3 participants
@kpsherva @ntarocco @zzacharo