Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate wheel building and testing #262

Merged
merged 9 commits into from
Feb 19, 2024

Conversation

SaillantNicolas
Copy link
Member

the wheel test is now in another job.

@lrineau
Copy link
Member

lrineau commented Jan 23, 2024

That creates a nice drawing of the graph of jobs, at https://github.com/CGAL/cgal-swig-bindings/actions/runs/7627051759?pr=262

Screenshot_20240123_152530

@lrineau lrineau linked an issue Jan 23, 2024 that may be closed by this pull request
@lrineau lrineau self-assigned this Jan 23, 2024
@lrineau
Copy link
Member

lrineau commented Jan 23, 2024

The Github actions will fail on Windows and MacOS, because of the upgrade to SWIG 4.2. @sloriot might come up with a proposal for a fix, eventually.

@lrineau lrineau marked this pull request as draft January 23, 2024 14:31
@lrineau lrineau marked this pull request as ready for review January 25, 2024 10:22
@lrineau
Copy link
Member

lrineau commented Jan 25, 2024

@SaillantNicolas:

I have fixed the CI in main (#263), and merge back main here. And also two improvements: 86efe52 and d210b99.

Now there are two issues:

  • on Windows, the expected failure of the test of the wheels (because TBB is not shipped),
  • on macOS, an incomprehensible error ERROR: cgal-5.6.post202401251314-cp39-cp39-macosx_10_9_x86_64.whl is not a supported wheel on this platform. There are probably several version of Python installed, and the wrong one is picked (note that Test Wheel (master, 3.12, macos-latest) does not fail, probably because the system Python is version 3.12).

See https://github.com/CGAL/cgal-swig-bindings/actions/runs/7654331055

@lrineau lrineau assigned SaillantNicolas and unassigned lrineau Jan 25, 2024
@lrineau
Copy link
Member

lrineau commented Jan 25, 2024

On Windows, we should use https://pypi.org/project/delvewheel/ to "fix" the wheel (like auditwheel on Linux and delocate on macOS).

Or maybe use https://github.com/jvolkman/repairwheel on all three platforms.

@lrineau lrineau merged commit 9354f0a into CGAL:main Feb 19, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test Python bindings wheels
2 participants