Update reserved paths based on Python 3.13 Windows changes #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
force-pushed
the
python-3.13-reserved-paths
branch
from
e556193
to
7dcbf4c
Compare
|
There are unrelated case-sensitivity problems on Windows and macOS that I'll address separately. |
dragly
approved these changes
Jun 19, 2024
Comment on lines
-36
to
+37
| exob._assert_valid_name("\n", f) | ||
| with pytest.raises(NameError): | ||
| exob._assert_valid_name("\n", f) |
There was a problem hiding this comment.
Nice, this is way more sensible! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
I will update the Python versions tested in CI separately, but this is passing using Tox with versions 3.7-3.13.