Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle none values in branch times #42

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Handle none values in branch times #42

merged 2 commits into from
Dec 17, 2024

Conversation

lewisjared
Copy link
Contributor

@lewisjared lewisjared commented Dec 17, 2024

Description

Fixes #38

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@bouweandela
Copy link
Contributor

This seems to work, but now I run into the next issue: #43

@lewisjared lewisjared merged commit d8c2f49 into main Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref dataset ingest fails if a file has no "branch_time_in_child" global NetCDF attribute
2 participants