Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reroute user to login via a button on the page. #52

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ATNoblis
Copy link
Collaborator

Summary

Fixing the infinite looped caused by trying to grab a valid user. If the user is not valid, allow them to login via a button

closes #44

Added

None

Changed

Added a button to home page. If an invalid response code was returned, allow the user to bedirected to login

Removed

None

Deprecated

None

@ATNoblis ATNoblis added bug Something isn't working enhancement New feature or request labels Sep 11, 2024
@ATNoblis ATNoblis self-assigned this Sep 11, 2024
@talentedmrjones
Copy link
Collaborator

Let's hide the user icon in the top right until logged in

@ATNoblis
Copy link
Collaborator Author

Let's hide the user icon in the top right until logged in

user icon is now hidden

@ATNoblis ATNoblis merged commit 2159fd9 into main Sep 13, 2024
1 check passed
@ATNoblis ATNoblis deleted the fix-reroute-button branch September 13, 2024 17:39
ATNoblis added a commit that referenced this pull request Sep 13, 2024
* fix: reroute user to login via a button on the page. This is to prevent a infinite loop to get a valid user.

* Hiding the user icon if a user is not logged in
ATNoblis added a commit that referenced this pull request Sep 14, 2024
* refactor: datatable

* fix: reroute user to login via a button on the page.  (#52)

* fix: reroute user to login via a button on the page. This is to prevent a infinite loop to get a valid user.

* Hiding the user icon if a user is not logged in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: redirect user to login if endpoint status isn't 2xx
2 participants