Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order of questionnare pillars with api updates #60

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

ATNoblis
Copy link
Collaborator

@ATNoblis ATNoblis commented Sep 19, 2024

Summary

Fix to the questionnaire modal to adapt to latest api updates. Ordering the questionnaire modal based on order of pillars. Updated Names of people to be capitalized

closes: #61

Added

None

Changes

Types.ts
QuestionnareModal.tsx
FismaTable.tsx

Removed

None

@ATNoblis ATNoblis added the bug Something isn't working label Sep 19, 2024
@ATNoblis ATNoblis self-assigned this Sep 19, 2024
Copy link
Collaborator

@talentedmrjones talentedmrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ATNoblis ATNoblis merged commit 305c0a9 into main Sep 19, 2024
1 check passed
@ATNoblis ATNoblis deleted the fix-questionnare-modal branch September 19, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Questionnare Modal is not handling latest api updates for the pillar orders
2 participants