Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-2841 Update package versions for Snyk #49

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

sharonfruit
Copy link
Contributor

JIRA Ticket:
BB2-2841

User Story or Bug Summary:
Updates package versions related to vulnerabilities found by Snyk.

What Does This PR Do?

Updates nodejs, axios and node-sass versions.

What Should Reviewers Watch For?

If you're reviewing this PR, please check these things, in particular:

  • Ensure it runs with docker compose.

@sharonfruit sharonfruit force-pushed the ssu/bb2-2841-update-versions-for-snyk branch from 8b5ef0f to 1339ca6 Compare January 4, 2024 18:52
@sharonfruit sharonfruit requested review from dtisza1 and ajshred January 4, 2024 18:55
Copy link

@ajshred ajshred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think in the future we will have to move on from node-sass though.

Copy link
Contributor

@dtisza1 dtisza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharonfruit This looks good to me!

Tested it locally in docker and works as expected.

@sharonfruit sharonfruit merged commit 35c6dae into master Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants