Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-2183Docker version upgrade to n20 #54

Merged

Conversation

noor1027
Copy link
Contributor

@noor1027 noor1027 commented Jun 3, 2024

JIRA Ticket:
BB-3183

User Story or Bug Summary:

What Does This PR Do?

This PR upgrades the Node.js version from depreciated node version to stable n20-slim version and this new version brings new EOL until Apr 2026

What Should Reviewers Watch For?

If you're reviewing this PR, please check these things, in particular:

  • Docker Builds for Client and server

@noor1027 noor1027 marked this pull request as ready for review June 3, 2024 12:57
@noor1027
Copy link
Contributor Author

noor1027 commented Jun 3, 2024

i have tested with upgraded node version and able to launch client
Screenshot 2024-06-03 at 8 08 07 AM
Client version

Copy link

@loganbertram loganbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward and everything still works!

Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@noor1027 noor1027 merged commit 2b12025 into master Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants