Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jimfuqian/BB2-3311 Remove selenium tests webdriver opt setting window-size #62

Conversation

JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Sep 17, 2024

JIRA Ticket:
BB2-3311

What Does This PR Do?

Remove Selenium Chrome webdriver opt setting: window-size
this results in the selenium tests VNC web UI rendering takes the default viewport setting which is preferred - page content centered and proportioned in the VNC view, better for tests user interaction checking and trouble shooting.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

Check out the PR to local and run a selenium tests remote or local
Start VNC viewer and observe the web UI interaction in VNC viewer
Expected: the web UI should be centered

Refer to this BB2 web server PR for VNC setup details:
CMSgov/bluebutton-web-server#1248

@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 28c0af0 into master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants