jimfuqian/BB2-3508 Replace CRA create react app with vite #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3508
Currently, our sample apps use the unmaintained create-react-app, which depends on the deprecated react-scripts lib. In order to fix these issues, we should remove these libraries and follow the steps to migrate to Vite from CRA.
What Does This PR Do?
Replace CRA (create-react-script) with Vite and perform refactor / version elevation etc as needed.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
For briefness, refer to "Validation" section of BB2 Python Sample App PR 84, verify similar steps and user experiences.
Note, sample app selenium tests (docker compose based) still broken see BB2-3315