Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4438 Check static site for 508 compliance via github actions #133

Merged
merged 9 commits into from
Dec 30, 2024

Conversation

jdettmannnava
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/DPC-4438

🛠 Changes

Added check_508_compliance workflow.

ℹ️ Context

We are moving our jobs from Jenkins to github actions. This is a clone of Jenkinsfile.static_site_508_compliance

🧪 Validation

Forced run worked: https://github.com/CMSgov/dpc-static-site/actions/runs/12380895523
Forced run with failure (running on ubuntu-latest meant it was blocked, so it tested the Cloudfront 403 response): https://github.com/CMSgov/dpc-static-site/actions/runs/12379865142/job/34554969116

@jdettmannnava jdettmannnava requested a review from a team December 20, 2024 19:56
@jdettmannnava jdettmannnava marked this pull request as ready for review December 20, 2024 19:56
Copy link
Contributor

@MEspositoE14s MEspositoE14s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This is more of a broad question than something just for this PR, but do we want to start building some of these as reusable workflows/composite actions?

@jdettmannnava
Copy link
Contributor Author

LGTM 👍

This is more of a broad question than something just for this PR, but do we want to start building some of these as reusable workflows/composite actions?

Yes! In fact, the other one does: CMSgov/dpc-app#2358

@jdettmannnava jdettmannnava merged commit 422b0df into main Dec 30, 2024
3 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4438-axe-static branch December 30, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants