Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The only valid choices for the
cms-hpt-validator
CLI script are currentlyv2.0
andv2.0.0
. However, there already exists av1.1
validator for earlier versions, but it is cannot currently be used due to the current choices constraint within themain()
method ofindex.ts
:.addArgument(new Argument("<version>").choices(["v2.0", "v2.0.0"]))
It was removed in this PR.
Solution
Added "v1.1" to the index.ts file, containing valid choices for the
cms-hpt-validator
script:.addArgument(new Argument("<version>").choices(["v1.1", "v2.0", "v2.0.0"]))
Result
The script will now successfully run the v1.1 validators from the
hpt-validator
repo ifv1.1
is passed as an argument theversion
parameter.Test Plan
CSV
The following command was run:
cms-hpt-validator "/<redacted>/eisenhower_standardcharges-20240628.csv" "v1.1" --format csv --error-limit 1000
And the following output was received:
JSON
Similarly, a JSON file was validated using "v1.1":
cms-hpt-validator "/<redacted>/472654841_cornerstone-specialty-hospitals-tucson_standardcharges.json" "v1.1" --format json --error-limit 1000