Redefine permission logic and Add tests for anonymous field and permissions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiefeng18
changed the title
J0nathanLai
requested changes
Oct 10, 2024
sophiefeng18
changed the title
sophiefeng18
changed the title
sophiefeng18
added
enhancement
J0nathanLai
approved these changes
Oct 10, 2024
|
Discussed why our own tests are failing. Not enough time to implement necessary changes that are outside the scope of our original implementation. |
This was
linked to
issues
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve: #18 #35 #15
Resolves: #41
Files Changed:
incorporated @J0nathanLai 's code for the anonymous field in src/posts/create.js
defined username display based on user role (admin or not) in src/posts/summary.js
added tests for anonymous field and permissions in test/posts.js
added safety check in src/controllers/search.js
cleaned up unnecessary code and console logs in src/api/posts.js, src/controllers/admin/privileges.js, src/middleware/user.js, and src/upgrades/1.4.4/sound_settings.js
Description:
Inside src/posts/summary.js, if the user is not admin, then the name showing up on anonymous posts would be "anonymous user." The test in test/posts.js checks if this logic plays out by setting up an admin user, a regular user, and an anonymous post posted by another regular user. The test checks if the admin user can see the username on the post while the regular user can only see "Anonymous User."
Justification for test not passing:
The test I wrote did not pass. The logic for the test should be correct, but the additional changes required to pass the test are beyond the scope of the implementation we made.