Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged refactored code from P1 #34

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

sophiefeng18
Copy link

Merged the refactored code from P1 in src/upgrades/1.4.4/sound_settings.js

@sophiefeng18 sophiefeng18 merged commit 79f27c9 into CMU-313:f24 Sep 23, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11001610829

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10996605803: -0.008%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants