Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for loading oh queue page #53

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Added test for loading oh queue page #53

merged 2 commits into from
Oct 9, 2024

Conversation

kmehta5
Copy link

@kmehta5 kmehta5 commented Oct 9, 2024

Resolves #52

Description:
Added a test to "testRoutes"' in test/controllers.js to test that oh queue page loads correctly. Deleted unnecessary commented out experimental code.

Files changed:
test/controllers.js

image

@kmehta5 kmehta5 added the enhancement New feature or request label Oct 9, 2024
@kmehta5 kmehta5 added this to the Sprint 2 milestone Oct 9, 2024
@kmehta5 kmehta5 requested a review from anna-mat October 9, 2024 22:50
@J0nathanLai J0nathanLai self-assigned this Oct 9, 2024
@kmehta5 kmehta5 assigned kmehta5 and unassigned J0nathanLai Oct 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11264261883

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.671%

Totals Coverage Status
Change from base Build 11263941027: 0.0%
Covered Lines: 22330
Relevant Lines: 25591

💛 - Coveralls

Copy link

@anna-mat anna-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I like that you followed the structure and formatting of the rest of the test file! Thanks for removing comments as well :)

@kmehta5 kmehta5 merged commit e79f821 into CMU-313:f24 Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to test suite for oh queue page
4 participants