Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the type&conversion handling around IO #63

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Aug 19, 2024

should close #62

@exaexa exaexa marked this pull request as draft August 19, 2024 11:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6b261e9) to head (fc313b7).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines          544       548    +4     
=========================================
+ Hits           544       548    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa exaexa marked this pull request as ready for review August 19, 2024 12:00
@exaexa exaexa requested a review from stelmo August 19, 2024 12:00
Copy link
Member

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@exaexa
Copy link
Member Author

exaexa commented Aug 19, 2024

@stelmo does the save_converted_model name sound OK? maybe it should say save_model_converted_by_path_extension but man, naming is hard

🇩🇪 variant: speichern_mit_dateinamenerweiterungkonvertierung, wonderful how this can be managed in 3 simple words

@exaexa exaexa merged commit 7ff2c2a into master Aug 19, 2024
4 checks passed
@exaexa exaexa deleted the mk-io-types branch August 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving StandardModel makes a model in wrong format
3 participants