Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize the FBC interface #65

Merged
merged 4 commits into from
Aug 20, 2024
Merged

stabilize the FBC interface #65

merged 4 commits into from
Aug 20, 2024

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Aug 20, 2024

I switched AbstractFBCModels to 1.0 so that we can add features without butchering compat. This just bumps the dependency in the correct way. Rest of the ecosystem got bumped as well, should follow moreless transparently.

@exaexa exaexa requested a review from stelmo August 20, 2024 12:29
@exaexa
Copy link
Member Author

exaexa commented Aug 20, 2024

depends on JuliaRegistries/General#113505

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ff2c2a) to head (48b1827).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines          548       548           
=========================================
  Hits           548       548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa exaexa merged commit 2bcfa16 into master Aug 20, 2024
4 checks passed
@exaexa exaexa deleted the mk-stabilize-fbc branch August 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants