Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement gapfilling #74

Merged
merged 7 commits into from
Sep 24, 2024
Merged

implement gapfilling #74

merged 7 commits into from
Sep 24, 2024

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Sep 24, 2024

closes #73

@exaexa exaexa requested a review from stelmo September 24, 2024 13:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (86b06b5) to head (30f6b18).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        38    +1     
  Lines          549       579   +30     
=========================================
+ Hits           549       579   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa exaexa marked this pull request as draft September 24, 2024 13:32
@exaexa
Copy link
Member Author

exaexa commented Sep 24, 2024

(Still needs coverage but lgtm other than that)

@exaexa exaexa marked this pull request as ready for review September 24, 2024 14:14
@exaexa exaexa merged commit 9497ad2 into master Sep 24, 2024
4 checks passed
@exaexa exaexa deleted the mk-gapfill branch September 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gap-filling / knock-in support
3 participants