Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a parallel reduction for isozyme_amount_variables #76

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Oct 16, 2024

On iML1515 this speeds up the building of enzymatic constraints from ~10s to ~200ms.

Thanks @HettieC for the testcase.

On iML1515 this speeds up the building of enzymatic constraints from ~10s to ~200ms.

Thanks @HettieC for the testcase.
@exaexa exaexa requested a review from stelmo October 16, 2024 11:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2263128) to head (b2a1b10).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        36    -2     
  Lines          579       576    -3     
=========================================
- Hits           579       576    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa
Copy link
Member Author

exaexa commented Oct 16, 2024

PS 😅 💦 💦 💦 💦

@stelmo
Copy link
Member

stelmo commented Oct 16, 2024

Wow!!!

@exaexa exaexa merged commit 6c200ef into master Oct 16, 2024
4 checks passed
@exaexa exaexa deleted the mk-fix-forgotten-preduce branch October 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants