Propose new 145 net layout #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up each subnet section to have uniform formatting
aHalliday13
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Lgtm, I cleaned up the formatting a bit. The only other thing I can think of is that it might make sense to define allocation boundaries along proper CIDR subnets, but I don't think there's any easy way to do that without moving existing devices to different addresses.
|
Any other comments or proposals on this? Would love to get an official layout written down even if it's not perfect. |
carykees98
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This layout works around where things are already - to my knowledge, there shouldn't be anything we have to move.