Show bathymetry plot in notebook + some other fixes #156
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hm... OK, it's a failed attempt... |
|
I think I fixed it! Could somebody review this? @aekiss, here's a preview of the docs showing that the thumbnail is there! |
There was a problem hiding this comment.
PR description doesn't capture the fix to rectangular_hgrid. One small typo in your doc changes, otherwise I think they're fine.
I guess this just makes the thumbnails for both notebooks the same. I suppose there's no issue with that (it's better than nothing!)
Co-authored-by: Angus Gibson <angus@agibson.me>
|
With #59 one of the examples will go away anyway |
That's a change only in the comments -- I'm adding a remark |
There was also an addition of deg2rad, no? |
|
In a comment tho, not in source code. |
@aekiss this PR adds the missing thumbnail.
It's not done in an automatic way, I just evaluated that particular cell.
Ideally, we need to resolve #119
Also some fixes in docstrings (eg
rectangular_grid) and in the explanations in the demo notebooks.