fix lint error check in controller and recorder body bytes in tests

COSSAS · May 14, 2024 · 6121451 · 6121451
1 parent 0d5c668
commit 6121451
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/internal/controller/controller.go b/internal/controller/controller.go
@@ -83,7 +83,10 @@ func (controller *Controller) NewDecomposer() decomposer.IDecomposer {
 	// NOTE: Enrolling mainCache by default as reporter
 	reporter := reporter.New([]downstreamReporter.IDownStreamReporter{})
 	downstreamReporters := []downstreamReporter.IDownStreamReporter{mainCache}
-	reporter.RegisterReporters(downstreamReporters)
+	err := reporter.RegisterReporters(downstreamReporters)
+	if err != nil {
+		log.Error("could not load main Cache as reporter for decomposer and executors")
+	}
 
 	actionExecutor := action.New(capabilities, reporter)
 	playbookActionExecutor := playbook_action.New(controller, controller, reporter)

diff --git a/test/integration/api/reporter_api_test.go b/test/integration/api/reporter_api_test.go
@@ -278,7 +278,7 @@ func TestGetExecutionReport(t *testing.T) {
 	app.ServeHTTP(recorder, request)
 
 	receivedData := api_model.PlaybookExecutionReport{}
-	err = json.Unmarshal([]byte(recorder.Body.String()), &receivedData)
+	err = json.Unmarshal(recorder.Body.Bytes(), &receivedData)
 	if err != nil {
 		t.Log(err)
 		t.Log("Could not parse data to JSON")

diff --git a/test/unittest/routes/reporter_api/reporter_api_test.go b/test/unittest/routes/reporter_api/reporter_api_test.go
@@ -130,7 +130,7 @@ func TestGetExecutionReportInvocation(t *testing.T) {
 	}
 
 	receivedData := api_model.PlaybookExecutionReport{}
-	err = json.Unmarshal([]byte(recorder.Body.String()), &receivedData)
+	err = json.Unmarshal(recorder.Body.Bytes(), &receivedData)
 	if err != nil {
 		t.Log(err)
 		t.Log("Could not parse data to JSON")