Feature/181 asynchronous return execution #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartendeKruijf
requested changes
Jul 23, 2024
| @@ -34,7 +34,7 @@ type ExecutionDetails struct { | |||
| } | |||
|
|
|||
| type IDecomposer interface { | |||
| Execute(playbook cacao.Playbook) (*ExecutionDetails, error) | |||
| Execute(playbook cacao.Playbook, details chan ExecutionDetails) (*ExecutionDetails, error) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I think we need a new interface to leave this one as is ExecuteAsync and Execute so the Playbook action step can be untouched.
internal/decomposer/decomposer.go
Outdated
| @@ -69,11 +69,18 @@ type Decomposer struct { | |||
| } | |||
|
|
|||
| // Execute a Playbook | |||
| func (decomposer *Decomposer) Execute(playbook cacao.Playbook) (*ExecutionDetails, error) { | |||
| func (decomposer *Decomposer) Execute(playbook cacao.Playbook, execution_details_ch chan ExecutionDetails) (*ExecutionDetails, error) { | |||
There was a problem hiding this comment.
The Exection details can be moved into two different functions and the rest of the execution can be doen in execute(..)
MaartendeKruijf
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added asynchronous logic to return execution details as soon as available