Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed via add forgotten cache result parsing for GET /reporter/ call #196

Conversation

lucamrgs
Copy link
Collaborator

@MaartendeKruijf how do we add schemes to the HTTP requests? It would have avoided this bug

@MaartendeKruijf
Copy link
Collaborator

@lucamrgs you can add an integration test which validates the output of the api. Otherwise we can look for an schema that we can enforce.

@lucamrgs
Copy link
Collaborator Author

@MaartendeKruijf we are validating the format now in the unit tests. But I saw we can use the // @schemes comment documentation to enforce that, but I remember trying when first implementing it and couldn't get it to work. Also we're not using it in any other route at the moment I think

@MaartendeKruijf
Copy link
Collaborator

@lucamrgs do you have a link to that?

@lucamrgs
Copy link
Collaborator Author

@MaartendeKruijf I was assuming you can do it with this https://github.com/swaggo/gin-swagger. But I looked at it and I am not sure it serves that purpose

@MaartendeKruijf MaartendeKruijf merged commit c1217ec into development Aug 1, 2024
9 checks passed
@MaartendeKruijf MaartendeKruijf deleted the bugfix/195-reporter-api-status-model-gives-integer-while-string-is-required branch August 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants