Feature/157 improve playbook execution speed by embedding the json schemas #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartendeKruijf
added
enhancement
RabbITCybErSeC
approved these changes
Aug 2, 2024
MaartendeKruijf
deleted the
feature/157-improve-playbook-execution-speed-by-embedding-the-json-schemas
branch
lucamrgs
reviewed
Aug 2, 2024
| sch, err = compiler.Compile(oca_cacao_schemas) | ||
| if err != nil { | ||
| return err | ||
| schemaUrl := utils.GetEnv("VALIDATION_SCHEMA_URL", "") |
There was a problem hiding this comment.
How do we handle this logic so that we can automatically re-build the local schemas if they change?
| if schemaUrl != "" { | ||
| return validateWithRemoteSchema(rawJson, schemaUrl) | ||
| } else { | ||
| return validateWithLocalSchema(rawJson) |
There was a problem hiding this comment.
Should we perhaps also have an option "build local schemas", invoked once when building the code, which populates the schemas according to the latest version? Or something along those lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added local cacao schemas for offline operation and speed increase.
The schemas used are: https://raw.githubusercontent.com/opencybersecurityalliance/cacao-roaster/main/lib/cacao-json-schemas/schemas/playbook.json
Go embed is used in combination with string schema building see: