Bugfix/223 loading playbooks from database is missing authentication information #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The result of the update |
lucamrgs
previously approved these changes
Sep 10, 2024
models/decoder/cacao.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func SetPlaybookKeysAsId(playbook *cacao.Playbook) { | ||
| for key, workflow := range playbook.Workflow { |
There was a problem hiding this comment.
Perhaps does it make sense to rename workflow to step?
lucamrgs
approved these changes
Sep 10, 2024
lucamrgs
approved these changes
Sep 10, 2024
MaartendeKruijf
deleted the
bugfix/223-loading-playbooks-from-database-is-missing-authentication-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a patch to the playbook loading from database as the decode is not used but ID are patched individually