Feature/27 fin controller #44

MaartendeKruijf · 2024-03-12T19:28:51Z

No description provided.

lucamrgs

It looks alright, I don't have any particular remark on this

MaartendeKruijf linked an issue Mar 12, 2024 that may be closed by this pull request

Fin controller #27

Closed

MaartendeKruijf force-pushed the feature/27-fin-controller branch 2 times, most recently from e477131 to 5e0e403 Compare March 13, 2024 09:31

MaartendeKruijf marked this pull request as ready for review March 13, 2024 10:03

MaartendeKruijf requested review from hidde-jan, RabbITCybErSeC and lucamrgs March 13, 2024 10:04

MaartendeKruijf self-assigned this Mar 13, 2024

MaartendeKruijf added the enhancement New feature or request label Mar 13, 2024

MaartendeKruijf force-pushed the feature/27-fin-controller branch from ee11b7a to 0d75af0 Compare March 13, 2024 14:04

MaartendeKruijf added 9 commits March 13, 2024 16:08

Updated fin protocol with name field

e61aafe

Updated fin struct with name field and id

9db05eb

Added Ack and Nack construction functions

a058ab8

Added fin controller

f46bcfd

Added manual fin controller test

76f028d

Removed space in json validation syntax

70b4411

Fixt lint issue

37ffa1a

Fixed linting issues

a365839

Added sample docker compose config moquitto

34f8897

MaartendeKruijf force-pushed the feature/27-fin-controller branch from 0d75af0 to 34f8897 Compare March 13, 2024 15:08

lucamrgs reviewed Mar 13, 2024

View reviewed changes

MaartendeKruijf added 3 commits March 14, 2024 09:33

Moved go routine into the class and removed unused arguments

41fafa5

Moved Connect and Subscribe to new function and added test

1cde4bd

Assert return is nil

bcd3292

MaartendeKruijf merged commit 10f6c6b into development Mar 14, 2024
9 checks passed

MaartendeKruijf deleted the feature/27-fin-controller branch March 14, 2024 09:10

Provide feedback