Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatten: avoid unnecessary sum decompositions #222

Merged
merged 1 commit into from
Feb 9, 2023
Merged

flatten: avoid unnecessary sum decompositions #222

merged 1 commit into from
Feb 9, 2023

Conversation

tias
Copy link
Collaborator

@tias tias commented Feb 7, 2023

Alternative and more extensive version of the optimisations Emilio implemented in the #114 branch.

I think its fairly solid, please have a look

sourdough-bread
sourdough-bread approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@sourdough-bread sourdough-bread left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For the test_flatten, I think we should give a specific name to the integer variables (self.iv) and boolvars (self.bv) which are stringified during the tests to ensure no errors if extra variables are created in the meantime.

@sourdough-bread sourdough-bread merged commit 192ea66 into master Feb 9, 2023
@sourdough-bread sourdough-bread deleted the flatten_sum_opt branch February 9, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourdough-bread sourdough-bread sourdough-bread approved these changes

@Wout4 Wout4 Awaiting requested review from Wout4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tias @sourdough-bread