Canonical recursive #432
Draft
Canonical recursive #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… edge cases with sum containing 1 var
|
After discussing offline: an alternative can be to merge this code into |
|
do we want to cover division as well? I guess it would make sense to do. |
Wout4
reviewed
Nov 8, 2023
|
|
||
| if lhs.name == "sum": | ||
| lhs_weights = [1]*len(lhs.args) + extra_weights |
There was a problem hiding this comment.
extra_weights will not be defined if the rhs is an operator other than sum or wsum (like div or mul or whatever)
Draft
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made canonical comparison fully recursive.
This covers some dangling edge cases I found such as having a sum with only one argument.
Also cleaned up the code a bit : )