Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is bool boolval #456

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Is bool boolval #456

merged 4 commits into from
Mar 4, 2024

Conversation

Wout4
Copy link
Collaborator

@Wout4 Wout4 commented Mar 1, 2024

fixes #452

@Dimosts
Copy link
Collaborator

Dimosts commented Mar 1, 2024

Why include BoolVal locally and not globally?

My comment has to do in general with the structure of the file and its imports. We import BoolVal locally 3 times, while I guess needing it 3 times is enough to do it globally.

At the same time, we include globally things we use only once (iterable, combinations, math) or dont even use (chain).

@Wout4
Copy link
Collaborator Author

Wout4 commented Mar 1, 2024

it's to avoid a cyclical import..
Don't know what the best way to deal with that is.
Other than that we just always use global imports.

Good point on removing unused imports though

@Wout4 Wout4 merged commit f7e5cbb into master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utils is_bool() does not include cpmpy BoolVal
2 participants