Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if minizinc executable is installed #494

Merged
merged 2 commits into from
Jun 25, 2024
Merged

check if minizinc executable is installed #494

merged 2 commits into from
Jun 25, 2024

Conversation

Wout4
Copy link
Collaborator

@Wout4 Wout4 commented Jun 17, 2024

No description provided.

@Wout4 Wout4 added the Simple to review Simple change to review, e.g., a oneliner. label Jun 17, 2024
@Wout4 Wout4 requested a review from ThomSerg June 18, 2024 17:56
ThomSerg
ThomSerg reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@ThomSerg ThomSerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, just some minor "cosmetic" changes.

cpmpy/solvers/minizinc.py Outdated Show resolved Hide resolved
cpmpy/solvers/minizinc.py Outdated Show resolved Hide resolved
@Wout4
change if to elif
d6144c6 
PEP 8 compliance
@Wout4 Wout4 merged commit 5495cc6 into master Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomSerg ThomSerg ThomSerg left review comments

Assignees
No one assigned
Labels
Simple to review Simple change to review, e.g., a oneliner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wout4 @ThomSerg