Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs improvement #506

Merged
merged 16 commits into from
Jul 25, 2024
Merged

Docs improvement #506

merged 16 commits into from
Jul 25, 2024

Conversation

ThomSerg
Copy link
Collaborator

An attempt to fix some of the issues I found with the documentation

  • inclusion of missing documentation
  • some small additions (like additional cross-reference links)

@Wout4
Copy link
Collaborator

Wout4 commented Jul 19, 2024

Nice, could already be merged or first we do those todo's

Copy link
Collaborator

@tias tias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super classy, rigorous and with non-trivial catches and additional explanations.

Even includes a todo : ) Maybe go over it with Wout?

Really great. Should be merged asap and definitely before the next release.

sphinx>=5.3.0 # cannot be updated due to m2r2 no longer being maintained -> switch to MyST?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know neither of the two, happy to switch to a maintained theme so we can keep sphinx up to date too yes!

@tias
Copy link
Collaborator

tias commented Jul 23, 2024

ah, Wout already reviewed it.

Do merge for users to immediately benefit, sphinx theme switch and additional todo's can go in future pull requests.

m2r2 is not longer actively maintained, causing issues with newer versions of sphinx. As a bonus, cross-referencing is now easier, allowing to directly write links to .rst files instead of their build .html counterparts.
@ThomSerg ThomSerg merged commit 42c193c into master Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants