Merge pull request #10 from mmlouamri/fix-vn

Fixing the Von Neumann Extractor
CQCL · Aug 20, 2024 · 9dabe5d · 9dabe5d
2 parents 1a4ccc1 + 450764b
commit 9dabe5d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/cryptomite/utils.py b/cryptomite/utils.py
@@ -284,4 +284,4 @@ def closest_na_set(k: int) -> int:
 
 def von_neumann(bits: BitsT) -> BitsT:
     """ Extract using Von-Neumann extractor. """
-    return [x for x, y in zip(bits[::2], bits[1::2]) if x == y]
+    return [x for x, y in zip(bits[::2], bits[1::2]) if x != y]
diff --git a/test/test_vn.py b/test/test_vn.py
@@ -3,11 +3,12 @@
 
 vn_testcases = [
     ([], []),
-    ([0, 1, 0, 1], []),
-    ([0, 0, 0, 0], [0, 0]),
-    ([0, 0, 1, 1], [0, 1]),
+    ([0, 1, 0, 1], [0, 0]),
+    ([0, 0, 0, 0], []),
+    ([0, 0, 1, 1], []),
+    ([0, 0, 0, 1, 1, 0, 1, 1, 1], [0, 1]),
     ([1, 0, 0, 0, 1, 0, 1, 0, 1, 1, 1, 1, 0, 0, 1, 1, 0, 1, 1, 0],
-     [0, 1, 1, 0, 1])
+     [1, 1, 1, 0, 1])
 ]