feat: Add Protocol for API objects #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnchildren
force-pushed
the
api-object-protocol
branch
3 times, most recently
from
0558e2a to
3f13d43
Compare
|
Please rebase and retarget to |
Fixes some type errors that have been seen by users and in other internal code. Also makes some methods public that were being used by QuantinuumBackend and fixes some mismatched types.
johnchildren
force-pushed
the
api-object-protocol
branch
from
3f13d43 to
cc117bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some type errors that have been seen by users and in other internal code. Also makes some methods public that were being used by QuantinuumBackend and fixes some mismatched types.
Description
This is a bit of a drive by PR, but this type issue was noticed by some users recently and is also an issue in some internal code. It looks like there were also some interface differences that adding this protocol raised. Possibly needs a bit more review as there may be some API changes that require a version bump.
Related issues
Please mention any github issues addressed by this PR.
Checklist