docs: fix invalid table in docs #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMacCQ
commented
Nov 21, 2024
| @@ -104,7 +104,7 @@ the circuit 2-qubit gate count is not reduced after compilation. | |||
| * - [AutoRebase [2]](inv:#*.AutoRebase) | |||
| - [SynthesiseTket](inv:#*.SynthesiseTket) | |||
| - [FullPeepholeOptimise [3]](inv:#*.passes.FullPeepholeOptimise) | |||
| - [RemoveBarriers](inv:#*.passes.RemoveBarriers) | |||
There was a problem hiding this comment.
Not sure why this first reference didn't resolve. Tested that this replacement works locally though.
There was a problem hiding this comment.
I don't know why it wouldn't work. Does this now show the name _tket in the docs? I think we want to avoid that.
There was a problem hiding this comment.
Yeah unfortunately I'll need to fix that in the TKET API docs. There's a replacement of all of the _tket names that isn't working currently. However I would've thought this resolver used module imports and that the module names on the webpage wouldn't matter.
EDIT: external links are done with intersphinx. See the intersphinx_mapping in docs/pytket-docs-theming/conf.py so the docs page does actually matter.
CalMacCQ
requested review from
cqc-alec
and removed request for
sjdilkes and
yao-cqc
cqc-alec
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fix. After #546 the table had an invalid number of columns and the
RemoveBarrierspass didn't show up. Should be fixed now.Fixed the pytket-qiskit one in CQCL/pytket-qiskit#421