Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bal 158 gp data on logout #163

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

gperissetcelteeka
Copy link
Collaborator

@gperissetcelteeka gperissetcelteeka commented Jul 26, 2023

Pre Release Version

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR
#158
#159
#160
#161
#162

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

BAL-159-GP-Distract wrong text
BAL-160-GP-Sort log
BAL-161-GP-Remove PHI and PII
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #163 (254b3d7) into main (e56c918) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #163      +/-   ##
========================================
- Coverage   3.15%   2.81%   -0.33%     
========================================
  Files        111     111              
  Lines       8653    8690      +37     
========================================
- Hits         272     244      -28     
- Misses      8381    8446      +65     
Files Changed Coverage Δ
...lance/ActivityLogging/ActivityLogButtonStyle.swift 0.00% <0.00%> (ø)
...lance/ActivityLogging/ActivityStorageManager.swift 0.00% <0.00%> (ø)
...nce/Distraction/Gallery/LookImages/ImageView.swift 0.00% <0.00%> (ø)
Balance/Home/Home.swift 0.00% <0.00%> (ø)
Balance/Profile/EmailHelper.swift 0.00% <0.00%> (ø)
Balance/Profile/ProfileCellView.swift 0.00% <0.00%> (ø)
Balance/Profile/ProfileView.swift 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56c918...254b3d7. Read the comment docs.

Copy link
Collaborator

@sebastianricaldoni sebastianricaldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gperissetcelteeka gperissetcelteeka merged commit 1aa591d into main Aug 1, 2023
5 checks passed
@gperissetcelteeka gperissetcelteeka deleted the feature/BAL-158-GP-Data-on-logout branch August 1, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants