fix importer to support DAP links as inputs

ravenpy/models/importers.py

@@ -775,13 +775,13 @@ def _check_gridcell_in_proximity_of_shape(
 
 class NcDataImporter:
     def __init__(self, fns):
-        self.fns = map(Path, fns)
+        self.fns = fns
         self.attrs = {}
         self._extract_nc_attrs(self.fns)
 
     def _extract_nc_attrs(self, fns):
         for fn in fns:
-            if ".nc" in fn.suffix:
+            if ".nc" in Path(fn).suffix:
                 with xr.open_dataset(fn) as ds:
                     # Check if any alternate variable name is in the file.
                     for var, alt_names in rv.alternate_nc_names.items():

tests/test_emulators.py

@@ -659,10 +659,7 @@ def test_dap(self):
             end_date=dt.datetime(2002, 1, 1),
             run_name="test",
             name="Salmon",
-            area="4250.6",
-            elevation="843.0",
-            latitude=54.4848,
-            longitude=-123.3659,
+            hrus=(GR4JCN.LandHRU(**salmon_land_hru_1),),
             params=model.params(0.529, -3.396, 407.29, 1.072, 16.9, 0.947),
         )