HBVEC emulator improvement #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an alias for rain snow fraction to match other emulators.
for more information, see https://pre-commit.ci
huard
approved these changes
Oct 10, 2024
5 tasks
lou-a
added a commit
to hydrologie/xhydro
that referenced
this pull request
Oct 16, 2024
… snow fraction for all models (#215) <!-- Please ensure the PR fulfills the following requirements! --> <!-- If this is your first PR, make sure to add your details to the AUTHORS.rst! --> ### Pull Request Checklist: - [ ] This PR addresses an already opened issue (for bug fixes / features) - This PR fixes #xyz - [ ] (If applicable) Documentation has been added / updated (for bug fixes / features). - [ ] (If applicable) Tests have been added. - [ ] CHANGELOG.rst has been updated (with summary of main changes). - [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`) has been added. ### What kind of change does this PR introduce? Improved the _ravenpy_models.py script to be able to specify the rain snow fraction for all models, including HBVEC. With the new version of RavenPy (v0.16.0, unreleased), the rain_snow_fraction could be set with "RainSnowFraction=rain_snow_fraction" in the self.default_emulator_config dictionary. See: CSHS-CWRA/RavenPy#408. For now (based on the latest release RavenPy version, v0.15.0) the change I'm suggesting here will enable changing the rain snow fraction algorithm for HBVEC as well. ### Does this PR introduce a breaking change? None foreseen. ### Other information:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Added an alias for rain snow fraction to match other emulators.
Does this PR introduce a breaking change?
This minor change should not lead to any breaking changes and it should be covered by emulator tests already included in the repo.
Other information: