DNM: Set INIT_ALL=zero #2046
Open
DNM: Set INIT_ALL=zero #2046
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
reviewed
Mar 14, 2024
brooksdavis
force-pushed
the
init-all-zero
branch
from
6a4423c
to
aa26ef8
Compare
|
We should take the first commit now |
|
For the record: spec benchmark results were disappointing with substantial regressions in some cases so further investigation is required. |
Zero portions of the stack the compiler can not prove are initialized before use or escape.
brooksdavis
force-pushed
the
init-all-zero
branch
from
aa26ef8
to
a787bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero bits of the stack the compiler can't prove are initialized before use or escape by default.
Needs a corresponding change to devel/llvm-base and sufficient benchmarking to demonstrate it's not a problem.