proccontrol: make -s require a target #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require a command to exec or a pid to target and update usage and the manpage to make this more clear. It makes no sense to invoke a procctl(2) command on the current process only to exit. Users are sometimes confused about how proccontrol works and think it effects their shell environment when invoked without a target. Disallowing this nonsensical behavior and clarifiying usage will hopefully reduce confusion. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D46422 (cherry picked from commit 70174ef7d2c80abdfca0e3ad9d0bb1af61318542) (cherry picked from commit 5cbb98c8259c48ba22c8359f4c14f5438329ce58)
|
What’s with the double cherry-pick? |
I squashed in the doc date bump I remember the moment after |
bsdjhb
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conflicts locally so merging now to hopefully save @bsdjhb some effort.
Require a command to exec or a pid to target and update usage and the manpage to make this more clear.
It makes no sense to invoke a procctl(2) command on the current process only to exit. Users are sometimes confused about how proccontrol works and think it effects their shell environment when invoked without a target. Disallowing this nonsensical behavior and clarifiying usage will hopefully reduce confusion.
Reviewed by: kib
Differential Revision: https://reviews.freebsd.org/D46422
(cherry picked from commit 70174ef7d2c80abdfca0e3ad9d0bb1af61318542) (cherry picked from commit 5cbb98c8259c48ba22c8359f4c14f5438329ce58)