[libunwind] Make libunwind_get_registers test pass on morello/aarch64. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just tested this now on an aarch64 box and it seems to pass as well. |
|
The current test is only checking the xregister subset, I wonder if we should write a full capability and use |
|
Probably makes sense to do the same for RISC-V? |
That sounds like a good idea. I'll open another PR with both the Morello and RISC-V tests changed. |
arichardson
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make Morello libunwind tests not fail anymore. I'm not too sure on my choice of
c10andc11(and their aarch64 equivalents), but they are not clobbered byunw_getcontextand I can't really imagine a scenario in this test where a compiler would do something with them. I also haven't tested this on aarch64 yet because I don't have anything to test it on, but it shouldn't break any other builds.