Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libunwind: Allow untagged pc under benchmark ABI #739

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

dpgao
Copy link

@dpgao dpgao commented Jun 12, 2024

Under the benchmark ABI, when making a function call that never returns, the link register might contain an untagged capability generated by a previous function return (Recall that returning under the benchmark ABI involves clearing the LSB of the address, clearing the tag at the same time).

@dpgao dpgao requested review from jrtc27 and dstolfa June 12, 2024 14:20
Copy link
Member

@jrtc27 jrtc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all the implications of this code, but this seems reasonable

@jrtc27
Copy link
Member

jrtc27 commented Jun 12, 2024

Please address the code style issue before merging

Under the benchmark ABI, when making a function call that never returns, the link register might contain an untagged capability generated by a previous function return (Recall that returning under the benchmark ABI involves clearing the LSB of the address, clearing the tag at the same time).
@dpgao dpgao changed the base branch from master to dev June 12, 2024 18:13
@dpgao dpgao merged commit 559dbe0 into dev Jun 12, 2024
0 of 2 checks passed
@dpgao dpgao deleted the dpgao-patch-2 branch June 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants