Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc #110

Merged
merged 22 commits into from
Dec 13, 2024
Merged

Misc #110

merged 22 commits into from
Dec 13, 2024

Conversation

jinningwang
Copy link
Member

@jinningwang jinningwang commented Dec 13, 2024

  • Breaking Change: rename model Region to Zone for clarity. Prior case files without modification can run into error.

Copy link

codacy-production bot commented Dec 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-3.13% (target: -10.00%) 86.76% (target: 0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (db9279e) 13316 8069 60.60%
Head commit (9a2a5e5) 13973 (+657) 8030 (-39) 57.47% (-3.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#110) 68 59 86.76%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (db9279e) to head (9a2a5e5).
Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
ams/core/model.py 50.00% 5 Missing ⚠️
ams/opt/constraint.py 50.00% 2 Missing ⚠️
ams/opt/optbase.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #110      +/-   ##
===========================================
- Coverage    79.32%   78.97%   -0.36%     
===========================================
  Files           70       70              
  Lines         6013     5993      -20     
===========================================
- Hits          4770     4733      -37     
- Misses        1243     1260      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinningwang jinningwang merged commit f01bfe7 into develop Dec 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant